[Sorry for the delay]
> So, I had failed to include Ada in my testing and my patch breaks it.
> In several ada/*.c files, we forcefully include system.h as a C header:
>
> #ifdef __cplusplus
> extern "C" {
> #endif
> ...
> #include "system.h"
> ...
> #ifdef __cplusplus
> }
> #endif
>
>
> Eric, is this really needed now? We are including gmp.h from system.h
> due to PR 54281. This is causing Ada builds to fail.
>
> Would it be OK to remove all the '#ifdef __cplusplus' conditionals from
> ada/*.c or is there something I'm missing?
The conditionals cannot be removed for the time being because the foreign
language interface of the Ada part of the compiler is hardcoded for C.
Barring a massive switch to the Ada language for the GNU project, we would need
to switch the foreign language interface to C++, which might introduce various
maintenance issues in the short term (Arno CCed).
--
Eric Botcazou
