On Wed, Jul 30, 2025 at 02:13:48PM -0700, Andrew Pinski wrote: > On Wed, Jul 30, 2025 at 4:18 AM Yury Khrustalev <yury.khrusta...@arm.com> > wrote: > > > > This optional header is used to bring in the definition of the > > struct __ifunc_arg_t type. Since it has been added to glibc only > > recently, the previous implementation had to check whether this > > header is present and, if not, it provide its own definition. > > > > This creates dead code because either one of these two parts would > > not be tested. The ABI specification for ifunc resolvers allows to > > create own ABI-compatible definition for this type, which is the > > right way of doing it. > > > > In addition to improving consistency, the new approach also helps > > with addition of new fields to struct __ifunc_arg_t type without > > the need to work-around situations when the definition imported > > from the header lacks these new fields. > > > > ABI allows to define as many hwcap fields in this struct as needed, > > provided that at runtime we only access the fields that are permitted > > by the _size value. > > All 3 patches are ok.
Thanks, merged now. > PS I was going to recommend that asm/hwcap.h and the HWCAP_ defines be > handled in a similar fashion and then I noticed that Wilco had a patch > which was not pushed; > https://inbox.sourceware.org/gcc-patches/CA+=Sn1n+86jG4-z89sNechq=xtqnnwe03erenkamwbzdb8r...@mail.gmail.com/T/#m604e753cd2cc91e8279d0976d4867d2c74cd6da3 Thanks for bringing this up! Wilco has just merge it: https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=a6bb6934a491015c4d3f08763455d86ccfb3bcbe Kind regards, Yury
