Public >> Public >> >> Hi, >> >>> I was going to apply this patch as it seems reasonable and independent >>> of everything else. But unfortunately it appears that you have munged >>> tabs into spaces. >>> >>> While we could potentially use "-l" to ignore that problem and allow the >>> patch to apply, but then the resulting change would have munged the tabs >>> into spaces, which violates our coding styles. >>> >>> For small isolated changes I don't mind fixing this stuff, but you have >>> dozens of changes and I don't have the time to fix each one you've >>> submitted. >>> >>> It's not clear if the patch was munged by your mailer or in your local >>> tree, but it definitely needs to get resolved before these patches can >>> go forward. >>> >>> Jeff >> >> It seems that the original patch wasn't munged. I used DavMail to send the >> original patch and verified its style using the contrib/check_GNU_style.sh >> script located in the GCC source tree. >> >> However, the ping was sent using Microsoft Outlook, which likely munged tabs >> into spaces for some reason. >> >> Could you please review the original patch from March 17, 2025, available at >> the following link, and try applying it again: >> https://sourceware.org/pipermail/gcc-patches/2025-March/677844.html > Done and pushed to the trunk. I don't have mips targets lit up in my > tester right now due to Jenkins issues from a couple weeks back. So I'm > flying a bit blind for MIPS stuff these days. Hopefully we don't muck > anything up. > > So the natural question is how to proceed in the more general sense. > I'd really like to avoid having to find the old patch, verify it hasn't > changed, etc. > > At the same time I understand you've been waiting a long time to move > things forward and don't want to waste your time. > > Suggestions on how to deal with this efficiently? > > Jeff
Hi Jeff, Thanks a lot for pushing the patch — I really appreciate it. Regarding MIPS testing, I understand the Jenkins situation and the limitations it imposes. If any regressions show up, I’ll be happy to help investigate and provide fixes. To make things easier for you, I am sending a summary email with direct links to the latest version of each patch from the mailing list. That way you won’t need to search through the archives manually. Please let me know if you'd prefer a different format or if there's anything else I can do to streamline the process. Best regards, Aleksandar [PATCH v2 1/1] Ensure _UNDER_TEST executables are target based: https://sourceware.org/pipermail/gcc-patches/2025-March/677859.html [PATCH v2 02/10] Only split shifts if using -mno-debugd: https://sourceware.org/pipermail/gcc-patches/2025-March/677841.html [PATCH v2 04/10] Add offset shrinking pass (-mshrink-offsets): https://sourceware.org/pipermail/gcc-patches/2025-March/677847.html [PATCH v2 05/10] P5600: Option -msched-weight added: https://sourceware.org/pipermail/gcc-patches/2025-March/677848.html [PATCH v2 06/10] Testsuite: Fix insn-*.c tests from trunk: https://sourceware.org/pipermail/gcc-patches/2025-March/677842.html [PATCH v2 07/10] Testsuite: Adjust tests to cope with -mips16: https://sourceware.org/pipermail/gcc-patches/2025-March/677849.html [PATCH v2 08/10] Testsuite: Skip tests making calls to variables: https://sourceware.org/pipermail/gcc-patches/2025-March/677845.html [PATCH v2 09/10] Remove redundant moves: https://sourceware.org/pipermail/gcc-patches/2025-March/677850.html [PATCH v2 10/10] nanoMIPS: unnecessary AND following an EXT: https://sourceware.org/pipermail/gcc-patches/2025-March/677851.html [PATCH v2 01/12] Testsuite: Fix tests properly for compact-branches: https://sourceware.org/pipermail/gcc-patches/2025-March/677827.html [PATCH v2 02/12] Fix unsafe comparison against stack_pointer_rtx: https://sourceware.org/pipermail/gcc-patches/2025-March/677829.html [PATCH v2 03/12] Improve store_by_pieces_p: https://sourceware.org/pipermail/gcc-patches/2025-March/677831.html [PATCH v2 04/12] Testsuite: Use HAS_LDC instead of a specific ISA: https://sourceware.org/pipermail/gcc-patches/2025-March/677833.html [PATCH v2 05/12] Testsuite: Disable the time-profiler-2.c test: https://sourceware.org/pipermail/gcc-patches/2025-March/677835.html [PATCH v2 06/12] Frame barrier fix: https://sourceware.org/pipermail/gcc-patches/2025-March/677837.html [PATCH v2 07/12] Lightweight fix for shrink-wrapping inhibition: https://sourceware.org/pipermail/gcc-patches/2025-March/677832.html [PATCH v2 08/12] Fix MSA SUBREG moves on big-endian targets: https://sourceware.org/pipermail/gcc-patches/2025-March/677834.html [PATCH v2 09/12] Add -mmxu and -mno-mxu driver pass through: https://sourceware.org/pipermail/gcc-patches/2025-March/677828.html [PATCH v2 10/12] Fix register spill issue for soft-float glibc 2.29: https://sourceware.org/pipermail/gcc-patches/2025-March/677836.html [PATCH v2 11/12] fmadd.w should be restricted to mipsr6: https://sourceware.org/pipermail/gcc-patches/2025-March/677838.html [PATCH v3 1/2] Add --with-multi-buildlist configure option: https://sourceware.org/pipermail/gcc-patches/2025-August/692516.html [PATCH v3 2/2] MIPS: Add support for --with-multi-buildlist: https://sourceware.org/pipermail/gcc-patches/2025-August/692517.html [PATCH v2 02/18] Hazard barrier return support: https://sourceware.org/pipermail/gcc-patches/2025-March/677810.html [PATCH v2 03/18] Add support for -mclib=[newlib,small,tiny]: https://sourceware.org/pipermail/gcc-patches/2025-March/677808.html [PATCH v2 04/18] Add microMIPS R6 support: https://sourceware.org/pipermail/gcc-patches/2025-March/677813.html [PATCH v2 05/18] Add support for -mdead-loads: https://sourceware.org/pipermail/gcc-patches/2025-March/677815.html [PATCH v2 06/18] Add -msdata-num and -msdata-opt-list support: https://sourceware.org/pipermail/gcc-patches/2025-March/677814.html [PATCH v2 07/18] Add -munique-sections feature: https://sourceware.org/pipermail/gcc-patches/2025-March/677817.html [PATCH v2 08/18] Add -mfunc-opt-list=<FILE>: https://sourceware.org/pipermail/gcc-patches/2025-March/677818.html [PATCH v2 09/18] Improve inlined memcpy: https://sourceware.org/pipermail/gcc-patches/2025-March/677819.html [PATCH v2 10/18] Add -march=interaptiv-mr2 with MIPS16E2: https://sourceware.org/pipermail/gcc-patches/2025-March/677823.html [PATCH v2 11/18] Add -minline-intermix to ignore mips16/nomips16: https://sourceware.org/pipermail/gcc-patches/2025-March/677821.html [PATCH v2 12/18] Load/store bonding improvements: https://sourceware.org/pipermail/gcc-patches/2025-March/677822.html [PATCH v2 13/18] Make rtl if-conversion more common: https://sourceware.org/pipermail/gcc-patches/2025-March/677824.html [PATCH v2 14/18] Test solution on dspmac builtins: https://sourceware.org/pipermail/gcc-patches/2025-March/677825.html [PATCH v2 15/18] Inefficient scattered double precision load in MSA: https://sourceware.org/pipermail/gcc-patches/2025-March/677812.html [PATCH v2 16/18] Inefficient 64-bit signed modulo by powers of two: https://sourceware.org/pipermail/gcc-patches/2025-March/677809.html [PATCH v2 17/18] Implement synthesised conditional xor/or: https://sourceware.org/pipermail/gcc-patches/2025-March/677820.html [PATCH v2 18/18] Check anti-dependence between 0 and 3 for loads: https://sourceware.org/pipermail/gcc-patches/2025-March/677816.html [PATCH v2 1/7] MIPSR6: Define new R6 FPU instructions: https://sourceware.org/pipermail/gcc-patches/2025-March/677795.html [PATCH v2 2/7] Inefficient scattered complex<float> load with MSA: https://sourceware.org/pipermail/gcc-patches/2025-March/677796.html [PATCH v2 3/7] MIPSR6: Fix ICE occurred in R6 target: https://sourceware.org/pipermail/gcc-patches/2025-March/677797.html [PATCH v2 5/7] Test float32-basic.c fails with -mabi=64 -EB: https://sourceware.org/pipermail/gcc-patches/2025-March/677799.html [PATCH v2 6/7] Performance degradation for iDCT-4M example: https://sourceware.org/pipermail/gcc-patches/2025-March/677800.html [PATCH v2 7/7] Add EHB after last load if branch within 16 inst.: https://sourceware.org/pipermail/gcc-patches/2025-March/677801.html
