On 8/15/25 11:54 AM, Austin Law wrote:
PR 121213 shows an unnecessary "li target,0" in an atomic exchange loop
on RISC-V.
The source operand for an amoswap instruction should allow (const_int 0)
in addition to GPRs. So the operand's predicate is changed to
"reg_or_0_operand". The corresponding constraint is also changed to
allow a reg or the constant 0.
With the source operand no longer tied to the destination operand we do
not need the earlyclobber for the destination, so the destination
operand's constraint is adjusted accordingly.
This patch does not address the unnecessary sign extension reported in
the PR.
Tested with no regressions on riscv32-elf and riscv64-elf.
PR target/121213
gcc/
* config/riscv/sync.md (amo_atomic_exchange<mode>): Allow
(const_int 0) as input operand. Do not tie input to output.
No longer earlyclobber the output
gcc/testsuite
* gcc.target/riscv/amo/pr121213: New test.
So just one more note. This also passed a bootstrap+regression test on
a BPI and Pioneer system.
The patchfile seems to be missing the test. But I've got a copy of the
test here which I'll use. When you do a git diff it'll ignore untracked
files. The way I usually deal with that is to git add the relevant
files, then git diff --cached to generate the patchfile.
I'll combine your patch with the testcase and push them to the trunk
momentarily.
Jeff
