Committed after making the changes. One small problem, I am not sure how to fix this:
The hyper link I referenced is : http://gcc.gnu.org/onlinedocs/gcc/X86-Built_002din-Functions.html#X86-Built_002din-Functions whereas the committed changes.html is pointing to: http://gcc.gnu.org/onlinedocs/gcc/X86-Built-in-Functions.html#X86-Built-in-Functions Please note that the "_002din" is missing. This makes the link broken, did I miss anything? I verified that I submitted the right link. Thanks, -Sri. On Tue, Aug 21, 2012 at 5:41 AM, Diego Novillo <dnovi...@google.com> wrote: > On 2012-08-20 22:41 , Sriraman Tallam wrote: >> >> Hi Gerald / Diego, >> >> I have made all the mentioned changes. I also shortened the >> description like Diego mentioned by removing all the strings but kept >> the caveats. I have not added a reference to the documentation because >> i do not know what link to reference. The builtins are completely >> documented in extend.texi. > > > Referring to the user's manual is OK, I think. > >> + <p>Caveat: If these built-in functions are called before any static >> + constructors are invoked, like during IFUNC initialization, then the >> CPU >> + detection initialization must be explicity run using this newly >> provided > > > s/explicity/explicitly/ > > Other than that, it looks fine to me. > > > Diego.