Ping!

Please review. 

Thanks & Regards
Kishan

On 24/07/25 8:48 pm, Kishan Parmar wrote:
> Hello,
>
> Changes from V1:
> Corrected Commit Message.
>
> Configure script previously accepted  unsupported  --with-long-double-64
> option  without  any  warning, leading  to  confusion.  This  option was
> mistakenly  documented in install.texi  but never  handled by  configure
> script, resulting in it being silently ignored.
>
> Patch updates configure script to error out  when  --with-long-double-64
> or --without-long-double-64  is  used, and instructs to use  the correct
> --without-long-double-128 or --with-long-double-128 option instead.
>
> Additionally, the mistaken  documentation  reference in install.texi has
> been corrected to reflect the actual supported option.
>
> 2025-07-23  Peter Bergner  <berg...@gcc.gnu.org>
>             Kishan Parmar  <kis...@linux.ibm.com>
>
> ChangeLog:
>       * configure.ac: Error out on --with-long-double-64.
>       * configure: Regenerate.
>
> gcc/ChangeLog:
>       * doc/install.texi: Remove incorrect mention of --with-long-double-64.
> ---
>  configure            | 15 +++++++++++++++
>  configure.ac         | 11 +++++++++++
>  gcc/doc/install.texi |  2 +-
>  3 files changed, 27 insertions(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index ccec3f21cd8..66c69c25c2e 100755
> --- a/configure
> +++ b/configure
> @@ -805,6 +805,7 @@ ospace_frag'
>  ac_user_opts='
>  enable_option_checking
>  with_build_libsubdir
> +with_long_double_64
>  with_system_zlib
>  with_zstd
>  enable_as_accelerator_for
> @@ -2965,6 +2966,20 @@ if test x$with_gnu_as = xno ; then
>    noconfigdirs="$noconfigdirs gas"
>  fi
>  
> +# Catch an invalid use of --with-long-double-64 early.
> +
> +# Check whether --with-long-double-64 was given.
> +if test "${with_long_double_64+set}" = set; then :
> +  withval=$with_long_double_64;
> +if test x$with_long_double_64 = xyes ; then
> +  as_fn_error $? "found --with-long-double-64 but use 
> --without-long-double-128 instead" "$LINENO" 5
> +else
> +  as_fn_error $? "found --without-long-double-64 but use 
> --with-long-double-128 instead" "$LINENO" 5
> +fi
> +
> +fi
> +
> +
>  use_included_zlib=
>  
>  # Check whether --with-system-zlib was given.
> diff --git a/configure.ac b/configure.ac
> index 89ebe4041b6..33487cea5ff 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -241,6 +241,17 @@ if test x$with_gnu_as = xno ; then
>    noconfigdirs="$noconfigdirs gas"
>  fi
>  
> +# Catch an invalid use of --with-long-double-64 early.
> +AC_ARG_WITH(long-double-64,
> +[],
> +[
> +if test x$with_long_double_64 = xyes ; then
> +  AC_MSG_ERROR([found --with-long-double-64 but use 
> --without-long-double-128 instead])
> +else
> +  AC_MSG_ERROR([found --without-long-double-64 but use 
> --with-long-double-128 instead])
> +fi
> +])
> +
>  use_included_zlib=
>  AC_ARG_WITH(system-zlib,
>  [AS_HELP_STRING([--with-system-zlib], [use installed libz])])
> diff --git a/gcc/doc/install.texi b/gcc/doc/install.texi
> index 09ea87aa812..f787c78b28e 100644
> --- a/gcc/doc/install.texi
> +++ b/gcc/doc/install.texi
> @@ -2455,7 +2455,7 @@ Linux systems and on big endian 64-bit systems where 
> the default cpu
>  is at least power7 (i.e.@: @option{--with-cpu=power7},
>  @option{--with-cpu=power8}, or @option{--with-cpu=power9} is used).
>  
> -If you use the @option{--with-long-double-64} configuration option,
> +If you use the @option{--without-long-double-128} configuration option,
>  the @option{--with-long-double-format=ibm} and
>  @option{--with-long-double-format=ieee} options are ignored.
>  

Reply via email to