On 8/26/25 11:54, H.J. Lu wrote:
> On Mon, Aug 25, 2025 at 12:11 PM David Faust <david.fa...@oracle.com> wrote:
>>
>>
>>
>> On 8/25/25 10:33, Indu Bhagat wrote:
>>> On 8/25/25 8:08 AM, David Faust wrote:
>>>>
>>>>
>>>> On 8/22/25 23:49, Indu Bhagat wrote:
>>>>> On 8/6/25 9:26 AM, David Faust wrote:
>>>>>> CTF array encoding uses uint32 for number of elements. This means there
>>>>>> is a hard upper limit on array types which the format can represent.
>>>>>>
>>>>>
>>>>> Hi David,
>>>>>
>>>>> Thanks for the patch.
>>>>>
>>>>> Few nits. But otherwise the patch looks good. As you noted in the
>>>>> bugzilla, more fixes will be needed to fix the ctf_die_bitsize () return
>>>>> type and its consumers...
>>>>
>>>> Just to clarify, OK to push with the nits below addressed?
>>>>
>>>> (I'll follow up with the other fixes mentioned in the PR soon, just
>>>> been a little sidetracked recently)
>>>>
>>>
>>> Yes, IMO its good to be committed.
>>
>> And pushed, with the nits fixed.
>>
>
> gcc.dg/debug/ctf/ctf-array-7.c failed for 32-bit targets:
Yeah, sorry about that. Silly mistake. Just pushed a fix.
>
> Executing on host:
> /export/build/gnu/tools-build/gcc-gitlab/build-x86_64-linux/gcc/xgcc
> -B/export/build/gnu/tools-build/gcc-gitlab/build-x86_64-linux/gcc/
> /export/gnu/import/git/gitlab/x86-gcc/gcc/testsuite/gcc.dg/debug/ctf/ctf-array-7.c
> -m32 -fdiagnostics-plain-output -O0 -gctf -dA -ffat-lto-objects
> -fno-ident -S -o ctf-array-7.s (timeout = 300)
> spawn -ignore SIGHUP
> /export/build/gnu/tools-build/gcc-gitlab/build-x86_64-linux/gcc/xgcc
> -B/export/build/gnu/tools-build/gcc-gitlab/build-x86_64-linux/gcc/
> /export/gnu/import/git/gitlab/x86-gcc/gcc/testsuite/gcc.dg/debug/ctf/ctf-array-7.c
> -m32 -fdiagnostics-plain-output -O0 -gctf -dA -ffat-lto-objects
> -fno-ident -S -o ctf-array-7.s
> /export/gnu/import/git/gitlab/x86-gcc/gcc/testsuite/gcc.dg/debug/ctf/ctf-array-7.c:11:7:
> error: size of array 'rep' is too large
> /export/gnu/import/git/gitlab/x86-gcc/gcc/testsuite/gcc.dg/debug/ctf/ctf-array-7.c:12:5:
> error: size of array 'unrep' is too large
> /export/gnu/import/git/gitlab/x86-gcc/gcc/testsuite/gcc.dg/debug/ctf/ctf-array-7.c:16:5:
> error: size of array 'unrepdim' is too large
> FAIL: gcc.dg/debug/ctf/ctf-array-7.c (test for excess errors)
> /export/gnu/import/git/gitlab/x86-gcc/gcc/testsuite/gcc.dg/debug/ctf/ctf-array-7.c:11:7:
> error: size of array 'rep' is too large
> /export/gnu/import/git/gitlab/x86-gcc/gcc/testsuite/gcc.dg/debug/ctf/ctf-array-7.c:12:5:
> error: size of array 'unrep' is too large
> /export/gnu/import/git/gitlab/x86-gcc/gcc/testsuite/gcc.dg/debug/ctf/ctf-array-7.c:16:5:
> error: size of array 'unrepdim' is too large
> gcc.dg/debug/ctf/ctf-array-7.c: output file does not exist
> UNRESOLVED: gcc.dg/debug/ctf/ctf-array-7.c scan-assembler-times
> 0x12000000[\t ]+[^\n]*ctt_info 2
> gcc.dg/debug/ctf/ctf-array-7.c: output file does not exist
> UNRESOLVED: gcc.dg/debug/ctf/ctf-array-7.c scan-assembler-times
> 0x2000000[\t ]+[^\n]*ctt_info 1
> gcc.dg/debug/ctf/ctf-array-7.c: output file does not exist
> UNRESOLVED: gcc.dg/debug/ctf/ctf-array-7.c scan-assembler-times [\t
> ]+0xffffffff[\t ]+[^\n]*cta_nelems 1
> gcc.dg/debug/ctf/ctf-array-7.c: output file does not exist
> UNRESOLVED: gcc.dg/debug/ctf/ctf-array-7.c scan-assembler-times [\t
> ]+0xab[\t ]+[^\n]*cta_nelems 1
>
>
