On Wed, Sep 10, 2025 at 03:05:52PM +0530, Surya Kumari Jangala wrote: > > Hi Mike, > > On 24/07/25 12:47 am, Michael Meissner wrote: > > diff --git a/gcc/config/rs6000/rs6000-cpus.def > > b/gcc/config/rs6000/rs6000-cpus.def > > index 4a1037616d7..df833e3d54b 100644 > > --- a/gcc/config/rs6000/rs6000-cpus.def > > +++ b/gcc/config/rs6000/rs6000-cpus.def > > @@ -83,6 +83,8 @@ > > #define POWER11_MASKS_SERVER (ISA_3_1_MASKS_SERVER \ > > | OPTION_MASK_POWER11) > > > > +#define FUTURE_MASKS_SERVER POWER11_MASKS_SERVER > > + > > /* Flags that need to be turned off if -mno-vsx. */ > > #define OTHER_VSX_VECTOR_MASKS (OPTION_MASK_EFFICIENT_UNALIGNED_VSX > > \ > > | OPTION_MASK_FLOAT128_KEYWORD \ > > @@ -160,11 +162,21 @@ > > Please keep this list in order, and don't forget to update the > > documentation > > in invoke.texi when adding a new processor or flag. > > > > - Before including this file, define a macro: > > + Before including this file, define two macros: > > > > RS6000_CPU (NAME, CPU, FLAGS) > > + RS6000_CPU_ISA (NAME, CPU, FLAGS, CPU_ISA) > > + > > + where the arguments are the fields of struct rs6000_ptt. > > + > > + If RS6000_CPU_ISA is not defined, it will default to using RS6000_CPU > > and > > + ignoring the CPU_ISA argument. RS6000_CPU_ISA is used to define CPU ISA > > + bits that do not have an option associated with them. */> > > - where the arguments are the fields of struct rs6000_ptt. */ > > +#ifndef RS6000_CPU_ISA > > +#define RS6000_CPU_ISA(NAME, CPU, FLAGS, CPU_ISA) \ > > + RS6000_CPU(NAME, CPU, FLAGS) > > +#endif > Duplicate definition. This has been defined in rs6000.cc too.
Rs6000-cpus.def is included in several places, where the code including it defines RS6000_CPU, depending on what field is being used. In only one place is the CPU_ISA field used. It was simpler not to modify those other inclusions, and just provide a default definition. -- Michael Meissner, IBM PO Box 98, Ayer, Massachusetts, USA, 01432 email: meiss...@linux.ibm.com
