Hi Jerry and Harald, I committed the patch, less the whitespace changes, as r16-4282.
I'll deal with the whitespace at a later date. Cheers and thanks Paul On Tue, 7 Oct 2025 at 18:12, Harald Anlauf <[email protected]> wrote: > > Am 07.10.25 um 18:56 schrieb Jerry D: > > On 10/7/25 2:19 AM, Paul Richard Thomas wrote: > >> Hi All, > >> > >> The real content of this patch is far simpler that the size would seem > >> to imply. I started replacing 8 spaces with tabs in primary.cc and > >> resolve.cc. Once started, I couldn't stop :-) This job will be > >> completed at another time. > >> > >> The changes listed in the ChangeLog entries for array.cc, decl.cc and > >> gfortran.h are clear of whitespace pollution. primary.cc has only > >> whitespace changes, while the only real content in resolve.cc changes > >> occurs in the chunk at line 1132 in the patch. The chunk in > >> trans-array.cc is at line 1406. > >> > >> The ChangeLogs and comments say everything that needs to be said about > >> the patch. The core content of PRs 102240 and 102686 removes variable > >> and function symbols from the parameter expressions and replaces them > >> with parameter symbols. Likewise, the fix for PR93175 requires that > >> components of PDT type have complete parameter lists, including all > >> parameter names, and that they be applied consistently in > >> structure_alloc_comps. > >> > >> Regtests on FC42/x86_64. OK for mainline? > >> > >> Paul > > > > Tests OK and yes, lots of white-space. ;) > > > > OK for mainline. > > > > Jerry > > > > I'd suggest to collect the non-functional, pure whitespace changes into > a separate commit. This make it easier to handle potential merge > conflicts when backporting future fixes that touch nearby code. > > Harald >
