On Wed, Oct 08, 2025 at 12:22:12PM -0700, Andrew Pinski wrote:
> On Wed, Oct 8, 2025 at 12:00 PM Dimitar Dimitrov <[email protected]> wrote:
> >
> > The cselim pass is enabled only for targets that have conditional move
> > instructions.  Since pru-unknown-elf doesn't have such instructions, the
> > pass is not executed, and the test fails with:
> >
> >   gcc.dg/tree-ssa/cselim-2.c: dump file does not exist
> >   UNRESOLVED: gcc.dg/tree-ssa/cselim-2.c scan-tree-dump cselim 
> > "if-then-else store replacement: 3"
> >
> > Fix by explicitly enabling the cselim pass for this test.
> >
> > Ok for trunk?
> 
> LGTM. Based on the other testcases that look at cselim dump, this is
> the same method of fixing it there.
Thank you.  I'll take that as an indication that the patch is considered
obvious.  So I pushed it as r16-4333-gccb2a10820c14b.

> Plus this was my oversight sorry I had missed that when adding the testcase.
No issue.

Regards,
Dimitar

> 
> Thanks,
> Andrew
> 
> >
> > gcc/testsuite/ChangeLog:
> >
> >         * gcc.dg/tree-ssa/cselim-2.c: Pass -ftree-cselim option.
> >
> > Signed-off-by: Dimitar Dimitrov <[email protected]>
> > ---
> >  gcc/testsuite/gcc.dg/tree-ssa/cselim-2.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/gcc/testsuite/gcc.dg/tree-ssa/cselim-2.c 
> > b/gcc/testsuite/gcc.dg/tree-ssa/cselim-2.c
> > index 2964fcfe1ff..db58dd22e8a 100644
> > --- a/gcc/testsuite/gcc.dg/tree-ssa/cselim-2.c
> > +++ b/gcc/testsuite/gcc.dg/tree-ssa/cselim-2.c
> > @@ -1,5 +1,5 @@
> >  /* { dg-do compile } */
> > -/* { dg-options "-O2 -fdump-tree-cselim-stats -fno-ssa-phiopt" } */
> > +/* { dg-options "-O2 -ftree-cselim -fdump-tree-cselim-stats 
> > -fno-ssa-phiopt" } */
> >
> >  struct Loc {
> >      int x[3];
> > --
> > 2.51.0
> >

Reply via email to