Re: [PATCH] c: Fix i386 target attribute regression [PR 122180]

[Alfie Richards]

On 08/10/2025 08:26, Petr Vaněk wrote:

On Tue, Oct 07, 2025 at 04:03:19PM +0000, alfie.richa...@arm.com wrote:

From: Alfie Richards <alfie.richa...@arm.com>

Small fix for a regression I caused.

Reg tested on x86-unknown-linux-gnu and aarch64-unknown-linux-gnu.

Ok for master?

-- >8 --

My patch (r16-4182-g73888cefe6da65) broke another target (i386), which this
patch fixes.

The issue was the target_version code was incorrectly being triggered on
targets that do not support target_version semantics (i386).

        PR target/122180

gcc/c/ChangeLog:

        * c-decl.cc (pushdecl): Add TARGET_HAS_FMV_TARGET_ATTRIBUTE check.

gcc/testsuite/ChangeLog:

        * gcc.target/i386/pr122180.c: New test.

Hi,

I just tested that the patch fixes my issue PR122180.

Thanks,
Petr

Hi Petr,

Great thank you, I will push this today.

KR,
Alfie