> From: Jonathan Wakely <[email protected]> > Date: Tue, 7 Oct 2025 19:57:42 +0100
> On Tue, 7 Oct 2025 at 19:53, Jonathan Wakely <[email protected]> wrote: > > On Tue, 7 Oct 2025 at 18:31, Hans-Peter Nilsson <[email protected]> wrote: > > > Didn't look like this patch was in a series, so: > > > aren't all libstdc++-v3/config/cpu/*/atomicity.h unused? > > > > Not all of them, but maybe more than just i486 and cris, those are > > just the ones I've only confirmed so far. > > > > The config/cpu/generic/atomic_builtins/atomicity.h file will only be > > used if __atomic_fetch_add on _Atomic_word doesn't need to link to > > libatomic, which isn't necessarily true for all of these: > > > > config/cpu/cris/atomicity.h > > config/cpu/hppa/atomicity.h > > config/cpu/i386/atomicity.h > > config/cpu/i486/atomicity.h > > config/cpu/m68k/atomicity.h > > config/cpu/sh/atomicity.h > > config/cpu/sparc/atomicity.h > > > > I don't think we can remove it for i386 or 32-bit sparc because > > changing from the current spinlock based __exchange_and_add to using > > __atomic_fetch_add would be an ABI break. I just don't get how those remaining config/cpu/*/atomicity.h files can be reached, considering that config/cpu/cris/atomicity.h was not compiled for no obvious reason. But, I also don't see the latter file wasn't compiled. I'll have to check myself, I can't let go of this. brgds, H-P
