Hi Piyush,

On 10/12/25 21:26, Piyush Raj wrote:
> Hi,
> 
> Changes Since v1:
> - Added a new commit that introduces initial runtime tests to the BPF torture 
> testsuite.
> 
> Thanks

Thanks for all your work on this!  It is useful, and is quite nice.

In using this locally, I do have a few small suggestions for improvements
mostly around usability/errors that I will note in the individual patches.
But none of them are major, all could be improved in the future.

I am not sure whether as a reviewer in the backend I can approve this series,
and regardless would defer approval until Jose also gives the OK.

That said, I am happy with it overall and would like to have this in :)

> 
> 
> Piyush Raj (3):
>   contrib: add bpf-vmtest-tool to test BPF programs
>   testsuite: bpf: add DejaGnu board for bpf-unknown-none target
>   testsuite: bpf: Add initial BPF runtime tests
> 
>  contrib/bpf-vmtest-tool/README                |  78 +++++++
>  contrib/bpf-vmtest-tool/bpf.py                | 199 +++++++++++++++++
>  contrib/bpf-vmtest-tool/config.py             |  18 ++
>  contrib/bpf-vmtest-tool/kernel.py             | 209 ++++++++++++++++++
>  contrib/bpf-vmtest-tool/main.py               | 103 +++++++++
>  contrib/bpf-vmtest-tool/pyproject.toml        |  36 +++
>  contrib/bpf-vmtest-tool/tests/test_cli.py     | 167 ++++++++++++++
>  contrib/bpf-vmtest-tool/utils.py              |  27 +++
>  contrib/bpf-vmtest-tool/vm.py                 | 154 +++++++++++++
>  gcc/Makefile.in                               |   1 +
>  gcc/testsuite/boards/bpf.exp                  |  69 ++++++
>  .../gcc.target/bpf/torture/bpf-torture.exp    |  46 ++++
>  .../bpf/torture/invalid-memory-access.c       |  18 ++
>  gcc/testsuite/gcc.target/bpf/torture/memcpy.c |   5 +
>  .../gcc.target/bpf/torture/memmove.c          |   6 +
>  gcc/testsuite/gcc.target/bpf/torture/memset.c |   5 +
>  gcc/testsuite/gcc.target/bpf/torture/naked.c  |   3 +
>  gcc/testsuite/gcc.target/bpf/torture/nop.c    |   4 +
>  .../gcc.target/bpf/torture/trace_openat.c     |  23 ++
>  19 files changed, 1171 insertions(+)
>  create mode 100644 contrib/bpf-vmtest-tool/README
>  create mode 100644 contrib/bpf-vmtest-tool/bpf.py
>  create mode 100644 contrib/bpf-vmtest-tool/config.py
>  create mode 100644 contrib/bpf-vmtest-tool/kernel.py
>  create mode 100644 contrib/bpf-vmtest-tool/main.py
>  create mode 100644 contrib/bpf-vmtest-tool/pyproject.toml
>  create mode 100644 contrib/bpf-vmtest-tool/tests/test_cli.py
>  create mode 100644 contrib/bpf-vmtest-tool/utils.py
>  create mode 100644 contrib/bpf-vmtest-tool/vm.py
>  create mode 100644 gcc/testsuite/boards/bpf.exp
>  create mode 100644 gcc/testsuite/gcc.target/bpf/torture/bpf-torture.exp
>  create mode 100644 
> gcc/testsuite/gcc.target/bpf/torture/invalid-memory-access.c
>  create mode 100644 gcc/testsuite/gcc.target/bpf/torture/memcpy.c
>  create mode 100644 gcc/testsuite/gcc.target/bpf/torture/memmove.c
>  create mode 100644 gcc/testsuite/gcc.target/bpf/torture/memset.c
>  create mode 100644 gcc/testsuite/gcc.target/bpf/torture/naked.c
>  create mode 100644 gcc/testsuite/gcc.target/bpf/torture/nop.c
>  create mode 100644 gcc/testsuite/gcc.target/bpf/torture/trace_openat.c
> 

Reply via email to