Re: [PATCH v11 02/13] x86: fmv: Refactor FMV name mangling.

[Alfie Richards]

On 22/09/2025 20:50, Segher Boessenkool wrote:
Hi!
Hello!
Thank you for the review!>
On Wed, Sep 17, 2025 at 12:44:53PM +0000, alfie.richa...@arm.com wrote:
        * config/rs6000/rs6000.cc (rs6000_mangle_decl_assembler_name): New
        function.
        (rs6000_get_function_versions_dispatcher): Remove duplicated cgraph
        logic.
        (make_resolver_func): Refactor to use rs6000_mangle_decl_assembler_name
        for mangling.
        (rs6000_mangle_function_version_assembler_name): New function.

Strange to see (non-trivial) rs6000 stuff in a patch marked as x86 only.

Apologies for this, it was in an attempt to highlight the behaviour 
changes to x86 (whereas behaviour should be identical for all other 
targets).

This could use some restructuring.

The code is fine though, AFAICS.  Thanks!
Great! Thank you!>

Segher