On Fri, Oct 24, 2025 at 2:09 PM Tomasz Kamiński <[email protected]> wrote:
>
> From: Eric Pimentel Aguiar <[email protected]>
>
> When exporting declarations in a namespace with using declarations, the
> name must be fully qualified. Recently introduced std::full_extent{,_t},
> std:strided_slice, and std::submdspan_mapping_result broke module std
> and module std.compat.
>
> libstdc++-v3/ChangeLog:
>
>         * src/c++23/std.cc.in (std::strided_slice, std::full_extent_t)
>         (std::full_extent, std::submdspan_mapping_result): Add std
>         qualification.
>
> Reviewed-by: Jonathan Wakely <[email protected]>
> ---
> v2:
>  - trims commit message (remove testing comments)
>  - corrected ChangeLog entry - path was incorrect
>
> Pushed to trunk.

Sweet. Will keep these corrections in mind for future patches.
Thank you for the feedback!


>
>  libstdc++-v3/src/c++23/std.cc.in | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/libstdc++-v3/src/c++23/std.cc.in 
> b/libstdc++-v3/src/c++23/std.cc.in
> index e849307f186..4c11b1bf711 100644
> --- a/libstdc++-v3/src/c++23/std.cc.in
> +++ b/libstdc++-v3/src/c++23/std.cc.in
> @@ -1872,10 +1872,10 @@ export namespace std
>  #if __glibcxx_padded_layouts
>    using std::layout_left_padded;
>    using std::layout_right_padded;
> -  using strided_slice;
> -  using full_extent_t;
> -  using full_extent;
> -  using submdspan_mapping_result;
> +  using std::strided_slice;
> +  using std::full_extent_t;
> +  using std::full_extent;
> +  using std::submdspan_mapping_result;
>  #endif
>    // FIXME submdspan_extents, mdsubspan
>  }
> --
> 2.51.0
>

Reply via email to