Hi.
This patch looks good to me, thanks.
Le 2025-10-25 à 07 h 46, Rainer Orth a écrit :
Hi Iain,
Darwin is host-shared by default, and therefore builds jit for
—enable-languages=all.
The changes in r16-4527-gc11d9eaa8ac9ee are causing format mismatches on lines 3433
and 3449 of jit-recording.cc <http://jit-recording.cc/> because Darwin’s
uint64_t == long long unsigned int (and the format specifiers are %ld and %li).
It seems I cannot locate the post(s) about review of this patch on gcc-patches@
…
Oh, it was done on https://github.com/antoyo/libgccjit/pull/9 (because
this was posted before the forge was up).
Sorry, we should have posted the messages on the ML.
Anyway, it’s not obvious to me whether for format specifiers need to be
changed, or the passed value needs to be casted (I have temporarily done the
second to make progress).
please could you take a look - or, if the second action is correct, let me know
and I’ll push that fix,
I've seen this myself and believe the following patch is the correct way
to print uint64_t, as is done in many other places. It passes
bootstrap on x86_64-apple-darwin25.0.0 and several earlier versions.
I won't be able to commit it myself if approved since I'm about to leave
for vacation soon.
Do you want me to push this patch for you?
Do I need a formal approval for this?
Rainer
