Those two tests slipped through the cracks as they happen to
work if offloading is enabled.

(That's a deficit in the current is-accessible
implementation as my system has USM, i.e. they would be
device accessible; I think we have a PR about this.)

In any case, the patch now uses again an invalid
(better: non-conforming) device number.

Committed as r16-5195-g2de6462c3800ff

Tobias
commit 2de6462c3800ff6a56e3d5ef4108a5de7f0f3757
Author: Tobias Burnus <[email protected]>
Date:   Wed Nov 12 14:15:43 2025 +0100

    libgomp.{c-c++-common,fortran}/target-is-accessible-1.c: Fix testcases for omp_default_device [P119677]
    
    Commit r16-5188-g5da963d988e8ea added omp_default_device such that -5
    became a conforming device number, but the tests used them to test
    for as non-conforming number; now -6 is used.
    
    libgomp/ChangeLog:
    
            PR libgomp/119677
    
            * testsuite/libgomp.c-c++-common/target-is-accessible-1.c: Modify
            test as -5 is now a conforming device number.
            * testsuite/libgomp.fortran/target-is-accessible-1.f90: Likewise.
---
 libgomp/testsuite/libgomp.c-c++-common/target-is-accessible-1.c | 2 +-
 libgomp/testsuite/libgomp.fortran/target-is-accessible-1.f90    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/libgomp/testsuite/libgomp.c-c++-common/target-is-accessible-1.c b/libgomp/testsuite/libgomp.c-c++-common/target-is-accessible-1.c
index 2e75c6300ae..71d6b2a8360 100644
--- a/libgomp/testsuite/libgomp.c-c++-common/target-is-accessible-1.c
+++ b/libgomp/testsuite/libgomp.c-c++-common/target-is-accessible-1.c
@@ -20,7 +20,7 @@ main ()
   if (!omp_target_is_accessible (p, sizeof (int), omp_initial_device))
     __builtin_abort ();
 
-  if (omp_target_is_accessible (p, sizeof (int), -5))
+  if (omp_target_is_accessible (p, sizeof (int), -6 /* omp_default_device - 1 */))
     __builtin_abort ();
 
   if (omp_target_is_accessible (p, sizeof (int), n + 1))
diff --git a/libgomp/testsuite/libgomp.fortran/target-is-accessible-1.f90 b/libgomp/testsuite/libgomp.fortran/target-is-accessible-1.f90
index 150df6f8a4f..2c25dca22f2 100644
--- a/libgomp/testsuite/libgomp.fortran/target-is-accessible-1.f90
+++ b/libgomp/testsuite/libgomp.fortran/target-is-accessible-1.f90
@@ -22,7 +22,7 @@ program main
   if (omp_target_is_accessible (p, c_sizeof (d), omp_initial_device) /= 1) &
     stop 3
 
-  if (omp_target_is_accessible (p, c_sizeof (d), -5) /= 0) &
+  if (omp_target_is_accessible (p, c_sizeof (d), -6) /= 0) &  ! -6 = omp_default_device - 1
     stop 4
 
   if (omp_target_is_accessible (p, c_sizeof (d), n + 1) /= 0) &

Reply via email to