On 11/17/25 2:41 PM, Sam James wrote:
> Martin Liška <[email protected]> writes:
>
>> Hello.
>>
>>> So this might break there, I don't know if this test would work with
>>> the hp linker though.
>>> (and yes hppa64-hp-hpux11 was working on the trunk as of a little over
>>> a month ago:
>>> https://gcc.gnu.org/pipermail/gcc-testresults/2025-October/858909.html).
>>
>> Fair point! Let's make the detection first use `--no-gc-sections`, and them
>> fall back to
>> without the option.
>>
>> I'm also including the ChangeLog in the V2 of the patch.
>
> The wild changes themselves LGTM now (not an approval, but I think Jeff's
> remark counts), but please drop the whitespace changes (or commit it
> separately, guess editor stripped on saving), and fix the extra newline
> added in gcc.cc.
Thank you Sam, the review was really useful.
The patch has been just applied.
Have a nice day,
Martin
>
> Also, s/wold/wild/ in ChangeLog.
>
>>
>> Thanks,
>> Martin
>
> thanks,
> sam
