On Tue, 4 Sep 2012, Oleg Endo wrote: > On Mon, 2012-09-03 at 01:58 +0200, Oleg Endo wrote: > > OKOK -- I'll do it :) > > (within the next couple of days) > > > > And so I did. Attached is an updated patch that adds the address space > parameter to the address_cost function. I hope that this change does > not reset the ACKs so far:
It helps if you CC port maintainers where approval is requested; you missed at least me. The CRIS and MMIX bits are ok (and obvious) whenever the generic bits are ok. Still, considering that we're C++ now, you can presumably drop the function parameter name instead of adding ATTRIBUTE_UNUSED. (Either that or the posted version is ok for CRIS and MMIX.) That goes for patches to trunk *only*. On patches likely to be backported to open branches (or local imports!), C++-syntax is unwanted. thanks. PS. please consider building cc1 for each target using contrib/config-list.mk or a similar script, to eliminate breaking typos. brgds, H-P
