On Fri, Dec 12, 2025 at 02:58:07PM +0000, Joseph Myers wrote:
> contrib/
> * test_installed (--enable-plugin, --with-plugincc=)
> (--with-plugincflags=, --with-gmpinc=): New options.
>
> gcc/
> * Makefile.in (PLUGIN_HEADERS): Add $(srcdir)/text-art/*.h.
> (install-plugin): Preserve directory structure for text-art
> headers.
>
> gcc/testsuite/
> * lib/plugin-support.exp (plugin-test-execute): Support installed
> testing.
> * g++.dg/plugin/plugin.exp, gcc.dg/plugin/plugin.exp,
> obj-c++.dg/plugin/plugin.exp, objc.dg/plugin/plugin.exp: Do not
> disable for installed testing.
Ok, with a small nit:
> @@ -87,6 +92,9 @@ Supported arguments:
> --with-alt-cxx=/some/compiler use specified alternative compiler in compat
> tests
> --with-compat-options=opts use specified COMPAT_OPTIONS in compat tests
> --with-libiconv=linker-args use given arguments to link with iconv
> [-liconv]
> +--with-plugincc=/some/cc use given host compiler to build plugins [g++]
Given that plugins are now written in C++, I think this should be
/some/c++ or /some/g++ or /some/dir/bin/g++ but not /some/cc.
> +--with-plugincflags=args use given options to build plugins [-g -O2]
> +--with-gmpinc=args use given options to find GMP for host []
Plus it is a question why we use PLUGINCC rather than PLUGINCXX variable,
or PLUGINCFLAGS rather than PLUGINCXXFLAGS but that is preexisting issue.
Jakub
