Hi Luc,
> On Solaris, same_as<int8_t, char> is true. Therefore, int8_t isn't a
> valid IndexType, because char is neither a signed nor an unsigned
> integer type.
>
> This commit fixes the tests by avoiding int8_t (and uint8_t) by using
> 'signed char' (and 'unsigned char').
>
> PR libstdc++/123176
>
> libstdc++-v3/ChangeLog:
>
> *
> testsuite/23_containers/mdspan/submdspan/submdspan_canonicalize_slices_neg.cc:
> Avoid
> int8_t with signed char.
>
> Signed-off-by: Luc Grosheintz <[email protected]>
> ---
>
> This fix is purely based on a theoretical understanding of the compiler
> messages reported in the bug report. Unfortunately, I don't have access
> to a Solaris machine; and therefore am not able to test on Solaris. I
> have tested on linux-x86_64.
in fact you do: there are both Solaris 11.4/SPARC and x86 hosts in the cfarm :-)
> I've CC'ed Rainer Orth who reported the issue, maybe Rainer's willing
> and has time to test it on Solaris.
Sure: it's way easier for me to just drop the patch into my source tree
and run the test. I just did so and it worked perfectly fine on both
i386-pc-solaris2.11 and sparc-sun-solaris2.11.
Thanks a lot.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
