> I am not sure this is the correct thing for this one. Because there
> could be some use out there that someone wants to use -Os multilib
> without disabling exceptions.

I've augmented the --enable-multilib-space option to take a third value,
'except'. With that option, the -Os variants do not get the
-fno-exceptions or -fno-asynchronous-unwind-tables options added.

> I suspect you want to have a separate multilib for this or maybe a
> configure option.

Yeah, perhaps someone will want to ship even more variants, but Zephyr
users appear to come in two camps -- "make it as small as possible, even
if I don't get all of the language features", and "just give me a
complete system, I've got lots of space". I hesitate to make this patch
even more complicated to support a mode which no-one has asked me for...

> Plus this changes the current --enable-target-optspace configure
> option to use -fno-exceptions which I am 99% sure is not a good thing.

I reviewed the patch and I don't think that was true -- it only looks
for Os in the compiler flags added by each multilib configuration, not
in the base compiler flags.

In any case, I've updated the patch to explicitly check for
multilib-space being enabled before grubbing through the multilib
options looking for Os. I had to do that to allow for
--enable-multilib-space=except. This should ensure that people *not*
using multilib-space don't get surprises.

With that change, I squashed the two multilib-space patches
together. I'm sending out an update patch series shortly.

-- 
-keith

Attachment: signature.asc
Description: PGP signature

Reply via email to