On Sun, 2026-01-25 at 19:41 +0000, Jonathan Wakely wrote: > On Sun, 25 Jan 2026 at 19:28, Jonathan Wakely <[email protected]> > wrote: > > > > > > > > On Sun, 25 Jan 2026, 16:06 Xi Ruoyao, <[email protected]> wrote: > > > > > > x86_64 glibc has started to use it since the 2.43 release. > > > > > > The correct fix is to #undef it for glibc then. That way it's still > > defined (and tested) for other targets. > > Like this: > > --- a/libstdc++-v3/testsuite/17_intro/names.cc > +++ b/libstdc++-v3/testsuite/17_intro/names.cc > @@ -303,8 +303,8 @@ > #if defined (__linux__) || defined (__gnu_hurd__) > #if __has_include(<features.h>) > #include <features.h> > -#if __GLIBC__ == 2 && __GLIBC_MINOR__ < 19 > -// Glibc defines this prior to 2.19
Oops I didn't see we already had this check. And I also forgot a ChangeLog. I shouldn't write the patch when I was sleepy. I'll send v2 soon. -- Xi Ruoyao <[email protected]>
