Frank Scheiner <[email protected]> writes:

> This is a follow-on to [1] now w/o RFC tag as Andrew confirmed in [2]
> that it is the correct approach. The message in the patch was now
> updated to mention that it fixes r10-2142-gec8ac265ff21fb as per [2],
> too - hence v2.
>
> [1]: https://gcc.gnu.org/pipermail/gcc-patches/2026-January/705623.html
>
> [2]: https://gcc.gnu.org/pipermail/gcc-patches/2026-January/705638.html

I can't approve it but it looks good to me. Thanks for handling it.

>
> ****
>
> Bootstrapping GCC (c, c++) on ia64 w/o support for LTO ([1]) showed that
> the testsuite (specifically c-c++-common/guality) executes tests with
> `-flto` although there was no support for LTO configured:
>
> [1]: https://gcc.gnu.org/pipermail/gcc-testresults/2025-December/865397.html
>
> Here for g++, but identical for gcc, too:
> ```
> [...]
> FAIL: c-c++-common/guality/Og-dce-1.c  -Og  line 13 *ptr == 1
> FAIL: c-c++-common/guality/Og-dce-1.c  -Og -flto (test for excess errors)
> UNRESOLVED: c-c++-common/guality/Og-dce-1.c  -Og -flto compilation failed to 
> produce executable
> FAIL: c-c++-common/guality/Og-dce-2.c  -Og -flto (test for excess errors)
> UNRESOLVED: c-c++-common/guality/Og-dce-2.c  -Og -flto compilation failed to 
> produce executable
> FAIL: c-c++-common/guality/Og-dce-3.c  -Og  line 17 x == 1
> FAIL: c-c++-common/guality/Og-dce-3.c  -Og  line 18 x == 101
> FAIL: c-c++-common/guality/Og-dce-3.c  -Og  line 20 x == 102
> FAIL: c-c++-common/guality/Og-dce-3.c  -Og -flto (test for excess errors)
> UNRESOLVED: c-c++-common/guality/Og-dce-3.c  -Og -flto compilation failed to 
> produce executable
> FAIL: c-c++-common/guality/Og-global-dse-1.c  -Og  line 13 gs1.i == 1
> FAIL: c-c++-common/guality/Og-global-dse-1.c  -Og  line 14 gs1.j == 2
> FAIL: c-c++-common/guality/Og-global-dse-1.c  -Og -flto (test for excess 
> errors)
> UNRESOLVED: c-c++-common/guality/Og-global-dse-1.c  -Og -flto compilation 
> failed to produce executable
> FAIL: c-c++-common/guality/Og-static-wo-1.c  -Og  line 13 x == 1
> FAIL: c-c++-common/guality/Og-static-wo-1.c  -Og -flto (test for excess 
> errors)
> UNRESOLVED: c-c++-common/guality/Og-static-wo-1.c  -Og -flto compilation 
> failed to produce executable
> [...]
>
>               === g++ Summary ===
>
> # of expected passes          245668
> # of unexpected failures      282
> # of unexpected successes     3
> # of expected failures                2188
> # of unresolved testcases     5
> # of unsupported tests                2221
> ```
>
> This is because [...]/guality.exp adds test permutations w/`-flto`
> unconditionally. Fix that by checking for LTO support and drop
> permutations w/`-flto` if unsupported.
>
> Tested successfully with `check-gcc RUNTESTFLAGS="dg.exp"`:
>
> Again for g++, but same for gcc:
> ```
> [...]
> FAIL: c-c++-common/guality/Og-dce-1.c  -Og  line 13 *ptr == 1
> FAIL: c-c++-common/guality/Og-dce-3.c  -Og  line 17 x == 1
> FAIL: c-c++-common/guality/Og-dce-3.c  -Og  line 18 x == 101
> FAIL: c-c++-common/guality/Og-dce-3.c  -Og  line 20 x == 102
> FAIL: c-c++-common/guality/Og-global-dse-1.c  -Og  line 13 gs1.i == 1
> FAIL: c-c++-common/guality/Og-global-dse-1.c  -Og  line 14 gs1.j == 2
> FAIL: c-c++-common/guality/Og-static-wo-1.c  -Og  line 13 x == 1
> [...]
>                 === g++ Summary ===
>
> # of expected passes            245668
> # of unexpected failures        278
> # of unexpected successes       3
> # of expected failures          2188
> # of unsupported tests          2208
> ```
>
> Suggested by Sam.
>
> Cheers,
> Frank
>
> [2. text/x-patch; 
> 0001-testsuite-only-test-with-LTO-if-LTO-support-is-actua.patch]...

Attachment: signature.asc
Description: PGP signature

Reply via email to