On 1/27/26 8:32 AM, Iain Sandoe wrote:
This implements the current working draft contracts including
National Body comment resolutions decided at the Nov 2025 WG21
meeting.

Is version 4 OK for trunk?
(I will need to tweak changelogs and update opt-urls before
  committing)

FWIW for this kind of revision, diffs from the previous revision would be helpful so I don't have to read the whole thing again. But I was able to look at the contracts_v3_patch_3_review and contracts_8_9_v3_review_iain branches to get about the same thing.

Just a couple bits that I noticed:

@@ -1007,7 +1005,7 @@ get_postcondition_result_parameter (tree fndecl)
     return NULL_TREE;
for (tree arg = DECL_ARGUMENTS (post); arg; arg = TREE_CHAIN (arg))

We can drop this line...

-    if (!TREE_CHAIN (arg))
+    if (tree_last (DECL_ARGUMENTS (post)))

...after this change.

       return arg;

+/* Map from the function decl of a wrapper to the function that it wraps.  */
+
+static GTY(()) hash_map<tree, tree> *decl_for_wrapper = nullptr;

Surely this can share with orig_from_outlined?

OK with the 'for' line above removed.

Jason

Reply via email to