Re: [PATCH] libga68: Use the internal malloc for UTF-32 to UTF-8 conversion

[Pietro Monteiro]

On Fri, Jan 30, 2026, at 3:11 AM, Jose E. Marchesi wrote:
> Hi Pietro.
>
> OK. Thanks!

I compiled libga68 with "-Wall -Wextra" and GCC warns about
_libga68_free_internal discarding the const qualifier and u8str being
uint8_t* instead of char*.  So I'm going to add the following to the
patch and push as obvious:

diff --git a/libga68/ga68-posix.c b/libga68/ga68-posix.c
index ef137933774..221fb1a19fe 100644
--- a/libga68/ga68-posix.c
+++ b/libga68/ga68-posix.c
@@ -57,7 +57,7 @@ void
 _libga68_posixperror (uint32_t *s, size_t len, size_t stride)
 {
   size_t u8len;
-  uint8_t *u8str = _libga68_u32_to_u8 (s, len, stride, &u8len);
+  char *u8str = _libga68_u32_to_u8 (s, len, stride, &u8len);
 
   const char *errstr = strerror (_libga68_errno);
   (void) write (2, u8str, u8len);
@@ -96,7 +96,7 @@ _libga68_posixfopen (const uint32_t *pathname, size_t len, 
size_t stride,
   int fd;
   int openflags = 0;
   size_t u8len;
-  const char *filepath = _libga68_u32_to_u8 (pathname, len, stride, &u8len);
+  char *filepath = _libga68_u32_to_u8 (pathname, len, stride, &u8len);
 
   /* Default mode: try read-write initially.
      If that fails, then try read-only.
@@ -138,7 +138,7 @@ _libga68_posixcreat (uint32_t *pathname, size_t len, size_t 
stride,
                     uint32_t mode)
 {
   size_t u8len;
-  const char *filepath = _libga68_u32_to_u8 (pathname, len, stride, &u8len);
+  char *filepath = _libga68_u32_to_u8 (pathname, len, stride, &u8len);
 
   int res = creat (filepath, mode);
   _libga68_errno = errno;
@@ -187,7 +187,7 @@ _libga68_posixgetenv (uint32_t *s, size_t len, size_t 
stride,
                      uint32_t **r, size_t *rlen)
 {
   size_t u8len;
-  const char *varname = _libga68_u32_to_u8 (s, len, stride, &u8len);
+  char *varname = _libga68_u32_to_u8 (s, len, stride, &u8len);
 
   char *val = getenv (varname);
   _libga68_free_internal (varname);
@@ -216,7 +216,7 @@ int
 _libga68_posixfputs (int fd, uint32_t *s, size_t len, size_t stride)
 {
   size_t u8len;
-  const char *u8str = _libga68_u32_to_u8 (s, len, stride, &u8len);
+  char *u8str = _libga68_u32_to_u8 (s, len, stride, &u8len);
 
   ssize_t ret = write (fd, u8str, u8len);
   _libga68_errno = errno;
@@ -366,7 +366,7 @@ _libga68_posixfconnect (uint32_t *str, size_t len, size_t 
stride,
                        int port)
 {
   size_t u8len;
-  const char *host = _libga68_u32_to_u8 (str, len, stride, &u8len);
+  char *host = _libga68_u32_to_u8 (str, len, stride, &u8len);
 
   /* Create a stream socket.  */
   int fd = socket (AF_INET, SOCK_STREAM, 0);

--
pietro