On Wed, 11 Feb 2026, Jakub Jelinek wrote:
> On Wed, Feb 11, 2026 at 12:03:26PM +0100, Jakub Jelinek wrote:
> > On Wed, Feb 11, 2026 at 11:39:37AM +0100, Richard Biener wrote:
> > > This makes use of dg-additional-options for the remainder of tests
> > > that were still getting those by filename based rules. This moves
> > > all those under the vect option iteration and slightly simplifies
> > > globbing by moving some files. I've kept the the veclower test glob.
> > > IMO remaining simplification either needs mass renaming of files or/and
> > > moving
> > > them into subdirectories. Possibly some regex or TCL expert can
> > > figure out how to filter bb-slp-*.c and vec-scal-*.c from everything
> > > else that's now catched by 17 inclusive regexp.
> > >
> > > Tested on x86_64-unknown-linux-gnu.
> > >
> > > OK for trunk now? I'm trying to get -march=x86-64-v3 clean and
> > > enable that as extra option iteration as followup.
> >
> > LGTM.
> >
> > Note, certainly not an TCL expert myself, but e.g. g++.dg/dg.exp uses
> > proc find-cxx-tests { dir suffix } {
> > set tests [lsort [glob -nocomplain -directory $dir "*.$suffix" ]]
> > foreach subdir [lsort [glob -nocomplain -type d -directory $dir *]] {
> > if { [glob -nocomplain -directory $subdir *.exp] eq "" } {
> > eval lappend tests [find-cxx-tests $subdir $suffix]
> > }
> > }
> > return $tests
> > }
> > Or maybe easier would be something like
> > [lsearch -all -not -inline -glob [lsearch -all -not -inline -glob [glob
> > -nocomplain $srcdir/$subdir/*.\[cS\]] $srcdir/$subdir/bb-slp-*.\[cS\]]
> > $srcdir/$subdir/vec-scal-*.\[cS\]]
> > or the same with some temporaries?
>
> Though, dunno how that scales when it needs to filter out 2 patterns.
> So
> set tests ""
> foreach file [glob -nocomplain $srcdir/$subdir/*.\[cS\]] {
> if { [string match $srcdir/$subdir/bb-slp-*]
> || [string match $srcdir/$subdir/vec-scal-*] } {
> } else
> eval lappend tests $file
> }
> or something like that is an option as well.
Hmm. If I move away vec-scal-* it would be \[^b\]*.\[cS\].
I could put those in as lower-*, no other existing ^l test is present.
Or simply have gcc.dg/vect/veclower/ and move them there. It's only
three tests though ...
Any preference?
Richard.
