On Thu, 19 Feb 2026 at 23:32, Andrew Pinski <[email protected]> wrote: > > On Thu, Feb 19, 2026 at 3:28 PM Andrew Pinski > <[email protected]> wrote: > > > > On Wed, Feb 18, 2026 at 1:08 PM Jonathan Wakely <[email protected]> wrote: > > > > > > This simplifies the v3-minimum-std procedure slightly, but the main > > > advantage is making v3_modules_std depend on v3_max_std so that we don't > > > have to update two separate variables when new effective targets such as > > > c++29 get added. > > > > I am getting these error messages now after this patch. > > > > +ERROR: tcl error code TCL WRONGARGS > > +ERROR: tcl error code TCL WRONGARGS > > +ERROR: tcl error code TCL WRONGARGS > > +ERROR: tcl error code TCL WRONGARGS > > +ERROR: tcl error sourcing > > /home/apinski/src/upstream-gcc-git/gcc/libstdc++-v3/testsuite/libstdc++-dg/conformance.exp. > > +ERROR: tcl error sourcing > > /home/apinski/src/upstream-gcc-git/gcc/libstdc++-v3/testsuite/libstdc++-dg/conformance.exp. > > +ERROR: tcl error sourcing > > /home/apinski/src/upstream-gcc-git/gcc/libstdc++-v3/testsuite/libstdc++-dg/conformance.exp. > > +ERROR: tcl error sourcing > > /home/apinski/src/upstream-gcc-git/gcc/libstdc++-v3/testsuite/libstdc++-dg/conformance.exp. > > +UNRESOLVED: testcase > > '/home/apinski/src/upstream-gcc-git/gcc/libstdc++-v3/testsuite/libstdc++-dg/conformance.exp' > > aborted due to Tcl error > > +UNRESOLVED: testcase > > '/home/apinski/src/upstream-gcc-git/gcc/libstdc++-v3/testsuite/libstdc++-dg/conformance.exp' > > aborted due to Tcl error > > +UNRESOLVED: testcase > > '/home/apinski/src/upstream-gcc-git/gcc/libstdc++-v3/testsuite/libstdc++-dg/conformance.exp' > > aborted due to Tcl error > > +UNRESOLVED: testcase > > '/home/apinski/src/upstream-gcc-git/gcc/libstdc++-v3/testsuite/libstdc++-dg/conformance.exp' > > aborted due to Tcl error > > +ERROR: wrong # args: should be "v3-minimum-std test default_std max_std" > > +ERROR: wrong # args: should be "v3-minimum-std test default_std max_std" > > +ERROR: wrong # args: should be "v3-minimum-std test default_std max_std" > > +ERROR: wrong # args: should be "v3-minimum-std test default_std max_std" > > So even though inside v3-minimum-std you changed to use the globals, > you didn't change the arguments of the proc: > proc v3-minimum-std { test default_std max_std } { > > So when you changed the code to call it to use only one: > - set min_std [v3-minimum-std $test $default_std $max_std] > - if { $min_std > $default_std } { > + set min_std [v3-minimum-std $test] > > We get an error.
Huh, I definitely had that change locally at some point, but then seem to have partially reverted it and pushed the broken form. I didn't see it because the final set of tests I did used v3_std_list in ~/.dejagnurc and so didn't use the v3-minimum-std proc. I'll fix it now...
