On 2/21/26 1:31 AM, Valentyn Yukhymenko wrote:
Bootstrapped and successfully run all 'dg.exp=reflect/*' tests on my 
x86_64-linux-gnu. Ok for trunk?

Thanks!  A few small notes:

Generally "OK for trunk?" indicates that the submitter has write access, which I don't think you do.

-- >8 --

Fixes a bogus "'Cls::<unnamed union>' is not a base of 'const Cls'" error when 
user tries to do a class member lookup using splice with reflection of anon union member.

The commit message should wrap at 76 columns so that it fits within 80 in 'git log'.

        PR c++/123642

gcc/cp/ChangeLog:

        * typeck.cc (finish_class_member_access_expr): Change context lookup to 
handle anon union members.

gcc/testsuite/ChangeLog:

        * g++.dg/reflect/member4.C: Change test case since it's allowed per 
class.mem.general/3.

Rationale belongs in code comments or the main commit message, not the ChangeLog entries.

I adjusted these two things and pushed the patch.  Thanks again.

Jason

Reply via email to