Hi Jakub!

Before we look into any code changes, let's first clarify the high-level
intentions:

On 2025-11-12T18:44:39+0800, Chung-Lin Tang <[email protected]> wrote:
> Currently because all the standard OpenMP/OpenACC headers and modules (omp.h, 
> openacc.h, omp_lib, etc.) are all part of libgomp, the compiler scan tests in 
> gcc/testsuite/*/gomp or gcc/testsuite/*/goacc cannot use them.
>
> This became somewhat pronounced when several Fortran uses_allocators tests 
> that had "use omp_lib" but were only compiler scan tests, had to be placed in 
> libgomp/testsuite.
>
> I am trying to place all scan-only tests inside gcc/testsuite/*, so came up 
> with the attached patch.
> This adjusts gomp.exp, goacc.exp, and gomp-goacc.exp in gcc/testsuite/* to 
> add -I<libgomp-build-directory> to the test compiler options. So far it works 
> as expected.

Jakub, do you remember the reason why for build-tree testing, contrary to
C++/libstdc++ for example, (the relevant) compiler-side test suites (that
is, the 'gcc/testsuite/' OpenACC/OpenMP '[...].exp' files) are not set up
to search the multilib's libgomp build directory?

If yes, please remind us of the rationale.  (..., and we shall then
properly document it.)

If no, is it OK to enable that functionality?  Secondly, we then shall
establish guidelines for which test cases must go into the libgomp test
suite (for a start, all execution test cases that are using more than one
CPU thread or offloading, so that they're governed by libgomp test
suite's "serialize execution testing via an exclusive lock").


Grüße
 Thomas

Reply via email to