Re: [PATCH 1/4] libgomp/gcn: parallelize initializing threads of a team

[Andrew Stubbs]

On 05/05/2026 14:14, Arsen Arsenović wrote:
+  /* TODO(arsen): This should be part of a mechanism that allows us to override
+     nthreads-var with OMP_NUM_THREADS.  But, we currently don't have access to
+     that list on the device.
+
+     thr->task->icv.nthreads_var = ...;  */

The previous code did write to this field. Why does the new thread not 
do at least the same? (This does not seem like "no functional changes".)

Here's the old code:

-  nthreads_var = icv->nthreads_var;
-  gomp_init_task (thr->task, task, icv);
-  team->implicit_task[0].icv.nthreads_var = nthreads_var;

I did not see any other issues in this patch.

Andrew