Rainer Orth <[email protected]> writes: > Several of the testsuite's effective targets are supposed to match the > result of configure tests. However, they often try to redo the tests, > which leads to code duplication and inconsistencies. > > Instead, this patch provides a framework to automatically generate > check_effective_target_<effective-target> procs that match an > auto-host.h macro and loads the result into targets.support.exp. > > While this patch was prompted by the overly complex implementations of > the o_flag_in_section and R_flag_in_section effective targets, those two > are riddled with so many other problems that fixing them would dwarf > the core of this patch. > > Instead, this uses the recently added HAVE_LD_AT_FILE check as a trivial > example. Just as HAVE_LD_AT_FILE was used to replace the current > HAVE_GNU_LD, this patch creates a new ld_at_file effective target, > replacing one use of the gld effective target. > > Bootstrapped without regressions on i386-pc-solaris2.11 (as/ld and > gas/gld) and x86_64-pc-linux-gnu.
I've been thinking about this on-off as well after noticing a few issues in current et checks. I like it (and I think the implementation looks good). Thanks. > > Ok for trunk? > > > As follow-ups, I mean to use this framework to either introduce new > effective targets, like solaris_as, solaris_ld or reimplement existing > ones. > > Rainer > [...] sam
signature.asc
Description: PGP signature
