On 2026-05-08 17:00, Torbjorn SVENSSON wrote:
On 2026-05-03 19:29, Jeffrey Law wrote:
On 4/9/2026 2:23 AM, Torbjorn SVENSSON wrote:
Gentle ping :)
Without this patch, all of the lto test fail on Windows (probably also
macOS with a case insensitive filesystem (the default setup for macOS)).
Kind regards,
Torbjörn
On 2026-04-02 21:01, Torbjörn SVENSSON wrote:
Ok for trunk and releases/gcc-15?
--
On a case insensitive filesystem, like on Windows, the "glob" function
in tcl returns an entry for each possible case that matches the
expression.
For example, `glob -nocomplain -types f -- "foo.{c,C}"` would return
both "foo.c" and "foo.C" even if there were only a "foo.c" file in the
directory.
gcc/testsuite/ChangeLog:
* lib/lto.exp: Make file listing case sensitive by doing case
sensitive filter after directory listing.
So this will match things like foo.F.xyz if I'm reading it correctly.
Probably not a big deal, but if it can be reasonably be fixed, we
probably should. And one typo in a comment, noted below.
Ahh, good catch!
I've updated the pattern to use ^ and $.
Signed-off-by: Torbjörn SVENSSON <[email protected]>
---
gcc/testsuite/lib/lto.exp | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/gcc/testsuite/lib/lto.exp b/gcc/testsuite/lib/lto.exp
index fc8a0673cd0..02afbe8cc64 100644
--- a/gcc/testsuite/lib/lto.exp
+++ b/gcc/testsuite/lib/lto.exp
@@ -711,9 +711,19 @@ proc lto-execute-1 { src1 sid } {
set i 1
set done 0
while { !$done } {
- set names [glob -nocomplain -types f --
"${dir}/${base}_${i}.{c,C,ii,\[fF\]{,90,95,03,08},d,m,mm}"]
+ set prefix "${dir}/${base}_${i}"
+
+ # glob returns a case insensitive list if filesystem is case
+ # insensitive. To have a case sensitive list, fetch the
extendend list
s/extendend/extended/
OK with those two issues addressed.
Pushed as r17-409-g8376a674e3564f.
I'll pick this for releases/gcc-15 and releases/gcc-16 end of next week unless
a regression is reported.
Pushed as r16-8918-gcc90f6578a0783 and r15-11171-g16b2d4fb5505db.
Kind regards,
Torbjörn
