On Sat, May 16, 2026 at 11:25:24AM +0200, Rainer Orth wrote:
> Darwin bootstrap is currently broken compiling libgomp/env.c:
>
> libgomp/env.c: In function 'initialize_env':
> libgomp/env.c:2476:7: error: use of logical '||' with constant operand
> '2097152' [-Werror=constant-logical-operand]
> 2476 | || GOMP_DEFAULT_STACKSIZE)
> | ^~
> libgomp/env.c:2476:7: note: use '|' for bitwise operation
> 2476 | || GOMP_DEFAULT_STACKSIZE)
> | ^~
> | |
>
> This is only seen on Darwin since this is the only target that defines a
> non-zero GOMP_DEFAULT_STACKSIZE.
>
> Bootstrapped without regressions on x86_64-apple-darwin25.5.0 and
> x86_64-apple-darwin21.6.0. Couldn't test on i386-apple-darwin17.7.0 or
> x86_64-apple-darwin17.7.0 since bootstrap there has been broken by HJ's
> patches for almost two weeks.
>
> Ok for trunk?
>
> Rainer
>
> --
> -----------------------------------------------------------------------------
> Rainer Orth, Center for Biotechnology, Bielefeld University
>
>
> 2026-05-16 Rainer Orth <[email protected]>
>
> libgomp:
> * env.c (initialize_env): Check GOMP_DEFAULT_STACKSIZE for
> non-zero.
LGTM. My fault apparently (both for -Wconstant-logical-operand
warning and this || GOMP_DEFAULT_STACKSIZE in PR79876).
Jakub
