Hi H.J.,
>> > > b/gcc/testsuite/gcc.dg/vect/complex/bb-slp-complex-mla-half-float.c
>> > > index 33e500f3f4c..831f84bc1c8 100644
>> > > --- a/gcc/testsuite/gcc.dg/vect/complex/bb-slp-complex-mla-half-float.c
>> > > +++ b/gcc/testsuite/gcc.dg/vect/complex/bb-slp-complex-mla-half-float.c
>> > > @@ -9,4 +9,6 @@
>> > > #include "complex-mla-template.c"
>> > >
>> > > /* { dg-final { scan-tree-dump "Found COMPLEX_FMA_CONJ" "slp1" { xfail
>> > > *-
>> > > *-* } } } */
>> > > -/* { dg-final { scan-tree-dump "Found COMPLEX_FMA" "slp1" { xfail
>> > > *-*-* } }
>> > > } */
>
> commit 44a31df54837adf2f7815e7966dfe8ac32eb8f3b
> Author: Artemiy Volkov <[email protected]>
> Date: Mon May 18 10:21:18 2026 +0000
>
> aarch64: introduce partial AdvSIMD vector modes
>
> changed gcc.dg/vect/complex/bb-slp-complex-mla-half-float.c to:
>
> -/* { dg-final { scan-tree-dump "Found COMPLEX_FMA" "slp1" { xfail
> *-*-* } } } */
> +/* { dg-final { scan-tree-dump "Found COMPLEX_FMA" "slp1" { xfail
> arm*-*-* } } */
>
> The end brace was missing. Add the missing end brace to fix it.
>
> PR testsuite/125489
> * gcc.dg/vect/complex/bb-slp-complex-mla-half-float.c: Add the
> missing end brace.
thanks for fixing this. However, it would have helped to point out that
this didn't affect just this single test but badly broke make check-gcc:
Running gcc/testsuite/gcc.dg/vect/complex/complex.exp ...
ERROR: tcl error sourcing gcc/testsuite/gcc.dg/vect/complex/../vect.exp.
unmatched open brace in list
while executing
"foreach op $tmp {
verbose "Processing option: $op" 3
set status [catch $op errmsg]
if { $status != 0 } {
if { 0 && [info exists errorInfo] } {..."
(procedure "saved-dg-test" line 76)
invoked from within
"saved-dg-test
gcc/testsuite/gcc.dg/vect/complex/bb-slp-complex-mla-half-float.c {} {-msse2
-ftree-vectorize -fno-tree-loo..."
("eval" body line 1)
invoked from within
"eval saved-dg-test $args "
(procedure "dg-test" line 4)
invoked from within
"dg-test $testcase $options ${default-extra-options}"
(procedure "dg-runtest" line 10)
invoked from within
"$runtest $testcases $flags ${default-extra-flags}"
(procedure "et-dg-runtest" line 22)
invoked from within
"et-dg-runtest dg-runtest [lsort [glob -nocomplain
$srcdir/$subdir/bb-slp-*.\[cS\]]] $flags $VECT_SLP_CFLAGS"
("foreach" body line 12)
invoked from within
"foreach flags $VECT_ADDITIONAL_FLAGS {
set tests ""
foreach file [glob -nocomplain $srcdir/$subdir/*.\[cS\]] {
if { ! [string match $srcdir/$..."
(file "gcc/testsuite/gcc.dg/vect/complex/../vect.exp" line 75)
invoked from within
"source gcc/testsuite/gcc.dg/vect/complex/../vect.exp"
("uplevel" body line 1)
invoked from within
"uplevel #0 source gcc/testsuite/gcc.dg/vect/complex/../vect.exp"
invoked from within
"catch "uplevel #0 source $file""
make[1]: Leaving directory
'/var/gcc/regression/master/6.17.13-gcc-gas-gld/build/gcc'
For sequential testing, this caused the whole testsuite run to abort.
For parallel testing, the affected subrun would be broken the same way.
So it's all the more important to understand that it's crucial to pay
close attention when testing testsuite patches.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
