Hi Naveen, This patch looks good, just 2 comments:
> - /* The immediate must repeat every eight bytes. */ > - unsigned int nbytes = bytes.length (); > - for (unsigned i = 8; i < nbytes; ++i) > - if (bytes[i] != bytes[i - 8]) > +/* The immediate must normally repeat every eight bytes. For MOV > + also allow a 128-bit AdvSIMD constant whose high 64 bits are zero > + since it can be materialized using a 64-bit MOVI. */ The indentation is wrong starting from this block (also missing tabs etc), can you fix that? Also it would be nice to have an extra testcase for fmov of a FP vector immediate. Cheers, Wilco
