On 6/11/2026 6:33 PM, Andrew Pinski wrote:
I am not comfortable with the heuristics used here for sink. This is
why I have not been heavily reviewing that part of the patch yet.
There has to be a better way of handling this. Maybe the better
heuristics is just handling this for the last sink rather than early
sink. There has to have some better way of handling the heuristics
rather than walking backwards.
The interaction with vectorization is a problem. We've seen that with
multiple transformations. I don't mind asking to explore some more ideas.
So are you suggesting deferring to post-vectorization and dropping the
heuristics that currently are meant avoid spoiling vectorization. That
seems like a reasonable space to ask Kyrill to explore.
I thought there is a way to tell if ssa name is based on an induction
variable or not. Which is way cheaper than what is done in this patch.
I thought we had this as well, but I can't find it anymore. We used it
in various places to avoid creating overlapping lifetimes in various
scenarios.
Jeff
