On Tue, 23 Jun 2026, Filip Kastl wrote:
> Hi Richi,
>
> handle_call_args gets called inside this if block.
>
> if (!in_ipa_mode
> || (fi->decl && fndecl && !fi->is_fn_info))
> {
>
> Do I understand correctly that fi->is_fn_info is false when we don't see the
> body of the function? If that's the case, this patch should be correct.
Yes.
> Didn't regtest nor bootstrap since this is a comment adjustment. Ok to push?
Minor adjustment ...
> Cheers,
> Filip Kastl
>
>
> --- 8< ---
>
>
> handle_call_args's comment suggests it is only called in non-IPA mode.
> That's not true. Adjust the comment to reflect that.
>
> gcc/ChangeLog:
>
> * gimple-ssa-pta-constraints.cc (handle_call_arg): Mention in
> comment that the function can get called in IPA mode.
>
> Signed-off-by: Filip Kastl <[email protected]>
> ---
> gcc/gimple-ssa-pta-constraints.cc | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/gcc/gimple-ssa-pta-constraints.cc
> b/gcc/gimple-ssa-pta-constraints.cc
> index bb59e533312..27ef7ca8784 100644
> --- a/gcc/gimple-ssa-pta-constraints.cc
> +++ b/gcc/gimple-ssa-pta-constraints.cc
> @@ -1464,9 +1464,9 @@ handle_call_arg (gcall *stmt, tree arg, vec<ce_s>
> *results, int flags,
> }
> }
>
> -/* For non-IPA mode, generate constraints necessary for a call on the
> - RHS and collect return value constraint to RESULTS to be used later in
> - handle_lhs_call.
> +/* For non-IPA mode or for functions whose bodies we cannot see.
for a function with body not available.
OK with that change.
Thanks,
Richard.
> + Generate constraints necessary for a call on the RHS and collect return
> + value constraint to RESULTS to be used later in handle_lhs_call.
>
> IMPLICIT_EAF_FLAGS are added to each function argument. If
> WRITES_GLOBAL_MEMORY is true function is assumed to possibly write to
> global
>
--
Richard Biener <[email protected]>
SUSE Software Solutions Germany GmbH,
Frankenstrasse 146, 90461 Nuernberg, Germany;
GF: Jochen Jaser, Andrew McDonald, Werner Knoblich; (HRB 36809, AG Nuernberg)
