[I just noticed you CCed [email protected] in your submission. I have
removed it from CC in this reply.]
Hi Agatha.
Thanks for the patch.
> [...]
> diff --git a/configure b/configure
> index 7b715db03e7..2c977bd7b9e 100755
> --- a/configure
> +++ b/configure
> @@ -9125,6 +9125,11 @@ if test "${with_mpfr_lib+set}" = set; then :
> fi
>
>
> +case "|x$with_mpfr|x$with_mpfr_include|x$with_mpfr_lib|" in
> + *"|xyes|"*)
> + as_fn_error $? "--with-mpfr{,-include,-lib} requires a PATH argument"
> "$LINENO" 5
> + ;;
> +esac
> if test "x$with_mpfr" != x; then
> gmplibs="-L$with_mpfr/lib $gmplibs"
> gmpinc="-I$with_mpfr/include $gmpinc"
> diff --git a/configure.ac b/configure.ac
> index 015cf150101..4997e2d6f5f 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1725,6 +1725,11 @@ AC_ARG_WITH(mpfr-lib,
> [AS_HELP_STRING([--with-mpfr-lib=PATH],
> [specify directory for the installed MPFR library])])
>
> +case "|x$with_mpfr|x$with_mpfr_include|x$with_mpfr_lib|" in
> + *"|xyes|"*)
> + AC_MSG_ERROR([--with-mpfr{,-include,-lib} requires a PATH argument])
> + ;;
> +esac
> if test "x$with_mpfr" != x; then
> gmplibs="-L$with_mpfr/lib $gmplibs"
> gmpinc="-I$with_mpfr/include $gmpinc"
I am wondering, in this and the other cases, wouldn't it be better to
handle --with-mpfr the same way than --with-mpfr= and --with-mpfr="",
which is to just ignoring it?
Something like:
if test "x$with_mpfr" != x -a "x$with_mpfr" != xyes; then
gmplibs="-L$with_mpfr/lib $gmplibs"
gmpinc="-I$with_mpfr/include $gmpinc"
fi
