;; Return 1 if op is an operand that can be loaded via the GOT.
-;; or non-special register register field no cr0
(define_predicate "got_operand"
(match_code "symbol_ref,const,label_ref"))
Most likely should be submitted and committed (as obvious) separately.
Yes, will do.
switch (mode)
{
- case QImode:
+ case QImode:
case HImode:
if (dest == NULL)
dest = gen_reg_rtx (mode);
Likewise.
Will do.
case 'Q':
- if (TARGET_MFCRF)
- fputc (',', file);
- /* FALLTHRU */
- else
+ if (! TARGET_MFCRF)
return;
+ fputc (',', file);
+ /* FALLTHRU */
case 'R':
/* X is a CR register. Print the mask for `mtcrf'. */
Likewise.
Will do.
/* Return the string to output a conditional branch to LABEL, which is
- the operand number of the label, or -1 if the branch is really a
+ the operand template of the label, or NULL if the branch is really a
conditional return.
OP is the conditional expression. XEXP (OP, 0) is assumed to be a
This looks like it should be done separately also.
OK.
+bool
+valid_vle_sd4_field (rtx mem, enum machine_mode mode)
No comment before this function.
I'll fix that.
- (simple_return "")])
+ (simple_return "1")])
Submitted separately it looks.
Sure.
libgcc/longlong.h
Gets sync'd with glibc's version sometimes.
Are you asking me to change something here?
Also have you thought have just adding a vle.md for all the needed
patterns and disabling the patterns in rs6000.md for VLE and not using
%^/%+/%- ? I think that would have been a cleaner implementation of
vle than adding support for it to the current patterns. Also does not
have the maintenance issue of always having to check if a new pattern
needs the %^/%+/%-.
The idea was discussed. A disadvantage is the code duplication it
would cause, which is also a maintenance headache. So we opted for the
current implementation. If the mainstream development causes a problem
for VLE it will be up to those interested in VLE to correct %^ etc.
--
Jim Lemke
Mentor Graphics / CodeSourcery
Orillia Ontario, +1-613-963-1073
