> -----Original Message----- > From: Alice Carlotti <[email protected]> > Sent: 15 July 2026 20:33 > To: [email protected] > Cc: Richard Earnshaw <[email protected]>; Tamar Christina > <[email protected]>; Kyrylo Tkachov <[email protected]>; Alex > Coplan <[email protected]>; Andrew Pinski > <[email protected]>; Wilco Dijkstra > <[email protected]> > Subject: [PATCH] aarch64: Fix assert checking alias feature bits > > Adjust the assert in aarch64_get_extension_string_for_isa_flags to check > that the isa_flags parameter has no alias bits set. This is the check I > intended to use when adding the assert in r15-7196-gb53781ce1e49fc, but > I accidentally checked the global aarch64_isa_flags value instead. > > > Ok for master? The existing assert should also never fire, so there's no need > to backport a fix. >
OK. Thanks, Tamar > > gcc/ChangeLog: > > * common/config/aarch64/aarch64-common.cc > (aarch64_get_extension_string_for_isa_flags): Check isa_flags. > > > diff --git a/gcc/common/config/aarch64/aarch64-common.cc > b/gcc/common/config/aarch64/aarch64-common.cc > index > fc7e84ae966c889ec1a666677bddc265e9b9e41c..d38ddb41c5964f17290e8 > 8732c83888b7b2597cd 100644 > --- a/gcc/common/config/aarch64/aarch64-common.cc > +++ b/gcc/common/config/aarch64/aarch64-common.cc > @@ -642,7 +642,7 @@ aarch64_get_extension_string_for_isa_flags > /* The alias bits should only be used to support the aliases > during option processing, and should be cleared at all other times. > Verify this property for the supplied flags bitmask. */ > - gcc_assert (!(feature_deps::alias_flags & aarch64_isa_flags)); > + gcc_assert (!(feature_deps::alias_flags & isa_flags)); > aarch64_feature_flags current_flags = default_arch_flags; > > /* As a special case, do not assume that the assembler will enable CRC
