On Thu, Jul 16, 2026 at 10:30:03AM -0400, Jason Merrill wrote:
> We currently accept "DR" tags as well as "PR" to indicate a C++ defect
> report, but the core language and library have different DR numbering and
> often we can implement an issue resolution before it becomes a formal DR.
> So let's also accept "CWG" and "LWG" tags.
> 
> contrib/ChangeLog:
> 
>       * gcc-changelog/git_commit.py (dr_regex): Add CWG|LWG.

LGTM.
I wonder if we also shouldn't accept
        C++NN PNNNNNRN - text
or maybe also or instead
        PNNNNNRN - text
?
I think that was what was used before the switch to git, now one
usually attempts to put it somewhere in the middle of the ChangeLog
entry, after some filename: at least.

Anyway, after committing this needs to be installed manually on sourceware
(I can do that).

> diff --git a/contrib/gcc-changelog/git_commit.py 
> b/contrib/gcc-changelog/git_commit.py
> index 6329e7eb07a..37c9b668cf9 100755
> --- a/contrib/gcc-changelog/git_commit.py
> +++ b/contrib/gcc-changelog/git_commit.py
> @@ -180,7 +180,7 @@ changelog_regex = re.compile(r'^(?:[fF]or 
> +)?([a-z0-9+-/]*)ChangeLog:?')
>  subject_pr_regex = 
> re.compile(r'(^|\W)PR\s+(?P<component>[a-zA-Z0-9+-]+)/(?P<pr>\d{4,7})')
>  subject_pr2_regex = re.compile(r'[(\[]PR\s*(?P<pr>\d{4,7})[)\]]')
>  pr_regex = re.compile(r'\tPR (?P<component>[a-z0-9+-]+\/)?(?P<pr>[0-9]+)$')
> -dr_regex = re.compile(r'\tDR ([0-9]+)$')
> +dr_regex = re.compile(r'\t(DR|CWG|LWG) ([0-9]+)$')
>  star_prefix_regex = re.compile(r'\t\*(?P<spaces>\ *)(?P<content>.*)')
>  end_of_location_regex = re.compile(r'[\[<(:]')
>  item_empty_regex = re.compile(r'\t(\* \S+ )?\(\S+\):\s*$')
> 
> base-commit: ddf645c09461c6ebf444f27ebbcad8141f0dba56

        Jakub

Reply via email to