On Fri Aug 14, 2026 at 12:19 AM WEST, David Malcolm wrote: > Sorry about the delay in reviewing this. > > Could you please split this patch up into two parts: > > (a) an initial part that just has these bits: > > gcc/analyzer/ChangeLog: > > * analyzer.cc (is_fndecl_in_toplevel_namespace_p): New function, > factored out of... > (is_std_function_p): ...here. Call it. > (is_cxxabi_function_p): New function. > * common.h (is_cxxabi_function_p): New decl. > * known-function-manager.cc (known_function_manager::get_match): > Also match functions declared in namespace __cxxabiv1. > > (b) everything else >
Initially I had split it into 2 commits like this, and then I merged them because I couldn't decide if I wanted to keep the split. I'll resubmit the patch into 2 commits. Egas > I think (a) is pretty-much ready to go. I'm attempting to review (b), > trying to compare it to cxx_eval_dynamic_cast_fn, but I'm not very > familiar with C++'s constexpr code, sorry.
