Claudio Bantaloukas (rdfm) <[email protected]> approved the changes:
Other than a typo in the commit message after "maintainer_utils: more array
size verification" and a wishlist that can be dealt with in a later patch, code
LGTM, but I'm not a global maintainer.
> +++ contrib/maintainer_utils.py
> @@ -299,0 +301,4 @@
> + validate(data)
> + if file:
> + fd = open(file, "w", encoding="utf-8")
> + print("# If you edit this file, please validate with:",
I would rather if this tried to open `pathlib.Path(__file__).parent.parent /
"MAINTAINERS.yml"`, read the first comment lines and reproduced them in the
output. It's ok if opening fails, don't print anything in that case.
This will avoid us having to keep two files in sync, allow us to write better
commentary in MAINTAINERS.yml and work with the overwhelming majority of uses
of store.
That being said, I'm happy with this change and the comment above is an
improvement that can come in a later patch.
--
https://forge.sourceware.org/gcc/gcc/pulls/222#issuecomment-7258
