Hi Jeff > Thanks. Please make sure to note how you've tested patches. For a > patch to the generic part of the compiler the patch must be bootstrapped > and regression tested on a major target (x86_64 and aarch64 are the most > common).
> I took care of throwing this into my tester overnight. While the > nightly runs aren't done, it did pass x86_64 and aarch64 with no > regressions. > However, it did flag a failure on riscv64-elf. In particular > gcc.target/riscv/pr123322.c fails. It's pretty obvious that the test in > question just needed to be updated for the improved code generation. > I've fixed that and pushed your patch to the trunk. Thank you very much for the review, for fixing the test, and for committing the patch. My local CI did not catch the gcc.target/riscv/pr123322.c failure. I’ll investigate why it was missed. Best regards, Wang Jue
