On 10/09/2026 14:37, Richard Sandiford wrote:
Building amdgcn-* fails with config-list.mk because of a diagnostic warning about:inform (UNKNOWN_LOCATION, "Try -foffload-options=-mxnack=any"); I know some people aren't fans of the diagnostic warnings, but I think in this case they're correct. The warning_at on the previous line starts with an abbreviation, so the uppercase letter seems correct there. Tested with config-list.mk. OK to install? FWIW, I tried to check whether there were tests for this exact message, but I couldn't see any. Richard gcc/ * config/gcn/gcn.cc (gcn_init_cumulative_args): Start the inform message with a lowercase letter. Quote the option name. --- gcc/config/gcn/gcn.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/config/gcn/gcn.cc b/gcc/config/gcn/gcn.cc index bbeaef3f927..e2a1e5d0e74 100644 --- a/gcc/config/gcn/gcn.cc +++ b/gcc/config/gcn/gcn.cc @@ -2999,7 +2999,7 @@ gcn_init_cumulative_args (CUMULATIVE_ARGS *cum /* Argument info to init */ , { warning_at (UNKNOWN_LOCATION, 0, "Unified Shared Memory is required, but XNACK is disabled"); - inform (UNKNOWN_LOCATION, "Try -foffload-options=-mxnack=any"); + inform (UNKNOWN_LOCATION, "try %<-foffload-options=-mxnack=any%>"); warned_xnack = 1; }
OK Andrew
