On 9/10/26 7:41 AM, Richard Sandiford wrote:
rtx_costs is supposed to store the cost in a provided pointer
and return true if the cost is complete. However, two places
in nds32_rtx_costs_speed_prefer returned the cost directly instead.
That in turn causes a build to fail with config-list.mk.
This doesn't seem to be an active port, so there's a legitimate
question whether we should preserve the existing behaviour
(by converting to return trues) or whether we should do what
the code presumably intended. I've gone for the latter option here.
Tested with config-list.mk. OK to install?
Richard
gcc/
* config/nds32/nds32-cost.cc (nds32_rtx_costs_speed_prefer): Fix
two places that returned a cost directly so that they now store
the cost in *total and return true.
I'd go with the likely code intent. My tester includes nds32be and
nds32le, though they do not have simulators, so while we can run the
testsuite, every execution tests are assumed to pass (by using a dummy
simulator that always exits with zero status). So we essentially get to
verify that all the execution tests will compile, assemble and link.
OK for the trunk. If there's any visible fallout, I'll let you know.
jeff
