"Robin Dapp" <[email protected]> writes: >> Yeah, I think the above is better. It's simpler, avoids a stack >> temporary, >> and at least stands a chance of using target optabs to insert the >> individual pieces. > > But if we need to spill in store_bit_field anyway (like for riscv), > wouldn't we even spill target once per iteration?
Yeah, but that would require some way of detecting what store_bit_field is going to do. For the V2DF in the testcase, there is at least a possibility that store_bit_field could use vec_set. Also, I still see the existing REGMODE_NATURAL_SIZE spills in store/extract_bit_field as a half-way measure: better than ICEing, but not what we want long-term. I don't think we should add spills elsewhere in anticipation of the existing spills, at least not if there is a simple alternative. It would just create more work that needs to be undone later. Richard
