Hi PA,

thanks for the update.

Paul-Antoine Arras wrote:
I added usm_env_handling-4.c and usm_env_handling-4-self.c. Both pass on my local GPU (nvptx). However, on gfx90a, all usm_env_handling-?.c tests (the ones setting GOMP_RUNTIME_USM "enabled") show up as unsupported. Is this expected?

[This was seemingly due DejaGNU not supporting dg-set-target-env-var with
remote testing; ]

Anyway, this was good to add this test as it uncovered missing conditions for GOMP_MAP_TO_GRID and GOMP_MAP_FROM_GRID in scan_sharing_clauses.

:-)

* * *

LGTM.

Thanks,

Tobias

PS: 'interdiff' looks scary, until one realizes that it failed half-way through.
directly comparing works (graphical 'diff'), but the difference also contains 
all
the post 1/3 changes that were reviewed before.

Reply via email to