On Wed, 16 Sep 2026, Tobias Burnus wrote: > Richard Biener wrote: > > I'm not sure, you pushed some of the changes under discussion, so > > [Slightly prematurely/accidentally early. As it wasn't really > wrong, I didn't want to revert it, though.] > > > I thought this one was off the table. [...] > > OK, I finally found the patch that I wanted to attach – but didn't > because I put it into the wrong directory and picked the latest > patch from the right directory. - And did not notice when I pinged! > > Sorry for the confusion! Attached is the patch I was actually > trying to talk about in my last two emails ...
Yeah, please go ahead. > > Note the removed 'offload_handle_link_vars' call; as written in the > previous email (which quotes the calls in the source code), this > call comes to early for handling renaming of same-named global > static variables stemming from multiple TU. Hence, calls were added > to later parts in the code (same function, indirectly in the 'if' > and directly in the 'else' branch). > However, the old call stayed - such that the function was always > called twice. This was redundant but only started failing > when creating the symtab node and not only invoked build_decl twice. > > Since it is now only called once, the 'DECL_HAS_VALUE_EXPR_P' check > could now be removed again! > > Sorry again! > > Tobias > > -- Richard Biener <[email protected]> SUSE Software Solutions Germany GmbH, Frankenstrasse 146, 90461 Nuernberg, Germany; GF: Stefan Gaiser, Jochen Jaser, Abhinav Puri; (HRB 36809, AG Nuernberg)
